Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add UDPRoute implementation #2363

Merged
merged 8 commits into from
Apr 1, 2022
Merged

Add UDPRoute implementation #2363

merged 8 commits into from
Apr 1, 2022

Conversation

rainest
Copy link
Contributor

@rainest rainest commented Mar 24, 2022

What this PR does / why we need it:
Adds a UDPRoute controller, UDPRoute parser code, and integration test.

Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes #2087

Special notes for your reviewer:
See #2087 (comment) for some of the design considerations and information on limitations (namely not being able to control the route destination port).

PR Readiness Checklist:

Complete these before marking the PR as ready to review:

  • the CHANGELOG.md release notes have been updated to reflect any significant (and particularly user-facing) changes introduced by this PR

@rainest rainest temporarily deployed to Configure ci March 24, 2022 22:24 Inactive
@rainest rainest temporarily deployed to Configure ci March 24, 2022 22:26 Inactive
@rainest rainest temporarily deployed to Configure ci March 24, 2022 22:26 Inactive
@rainest rainest mentioned this pull request Mar 24, 2022
4 tasks
@rainest rainest temporarily deployed to Configure ci March 28, 2022 20:11 Inactive
@rainest rainest temporarily deployed to Configure ci March 28, 2022 20:11 Inactive
@rainest rainest temporarily deployed to Configure ci March 28, 2022 20:16 Inactive
@rainest rainest temporarily deployed to Configure ci March 28, 2022 20:16 Inactive
@rainest rainest temporarily deployed to Configure ci March 28, 2022 20:23 Inactive
@rainest rainest temporarily deployed to Configure ci March 28, 2022 20:23 Inactive
@rainest rainest temporarily deployed to Configure ci March 28, 2022 20:44 Inactive
@rainest
Copy link
Contributor Author

rainest commented Mar 28, 2022

With #2087 (comment), most questions are relegated to either after experimental features become stable or until after changes to backendRef handling solidify, so this should be good to go.

@rainest rainest marked this pull request as ready for review March 28, 2022 20:45
@rainest rainest requested a review from a team as a code owner March 28, 2022 20:45
Copy link
Contributor

@shaneutt shaneutt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like most of this is copy/pasted. I may be forgetting something: what happened to the conversation about using a generator for these?

examples/gateway-udproute.yaml Show resolved Hide resolved
test/integration/udproute_test.go Show resolved Hide resolved
@rainest rainest temporarily deployed to Configure ci April 1, 2022 15:02 Inactive
@rainest rainest temporarily deployed to Configure ci April 1, 2022 15:03 Inactive
@rainest rainest temporarily deployed to Configure ci April 1, 2022 15:23 Inactive
@rainest rainest temporarily deployed to Configure ci April 1, 2022 16:09 Inactive
@rainest rainest temporarily deployed to Configure ci April 1, 2022 16:09 Inactive
@rainest rainest requested a review from shaneutt April 1, 2022 16:14
@rainest rainest temporarily deployed to Configure ci April 1, 2022 16:29 Inactive
@rainest rainest temporarily deployed to Configure ci April 1, 2022 19:17 Inactive
@rainest rainest temporarily deployed to Configure ci April 1, 2022 19:17 Inactive
@rainest rainest requested a review from shaneutt April 1, 2022 19:17
@rainest rainest temporarily deployed to Configure ci April 1, 2022 19:36 Inactive
@rainest rainest temporarily deployed to Configure ci April 1, 2022 21:11 Inactive
@rainest rainest enabled auto-merge (squash) April 1, 2022 21:12
@rainest rainest temporarily deployed to Configure ci April 1, 2022 23:04 Inactive
@rainest rainest temporarily deployed to Configure ci April 1, 2022 23:04 Inactive
@rainest rainest merged commit 0884dfc into main Apr 1, 2022
@rainest rainest temporarily deployed to Configure ci April 1, 2022 23:22 Inactive
@rainest rainest deleted the feat/udproute-controller branch April 1, 2022 23:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

UDPRoute Support
2 participants